Refactor visualize module into multiple files #357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The visualize module has grown to ~1000 lines, and we expect it to get longer as we introduce further functionality. This length is also making it difficult to run tools like Pylint, which consume more time with file size. Thus, this PR breaks the visualize module into multiple smaller files.
The best way to do this while preserving history is to create multiple branches where we make copies of visualize.py and then merge the copies. This has the drawback of adding many commits to master as we cannot squash the commits (that would destroy the history). For more information on this procedure of splitting files while maintaining history, see here.
In addition to the commits which copy visualize.py, this PR also adds a commit that tidies up the copies by removing the duplicated code.
TODO
_utils
Questions
Status
CONTRIBUTING.md
yapf
pytest
pylint
HISTORY.md