Include Content-Length response header #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The 'Content-Length' response header is expected by many clients. While it is not possible to specify the content length for on-the-fly compression, it is possible when sending an individual file. Modification: Update DataSelection to optionally return the content length. Update the 'getData' Response to include the `Content-Length` header when the request targets a single file that is not placed in a zip archive. If the content is dynamically generated (e.g., a zip file) then no `Content-Length` header is provided. Result: IDS now includes the `Content-Length` response header when this is possible Signed-off-by: Paul Millar <paul.millar@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The 'Content-Length' response header is expected by many clients. While it is not possible to specify the content length for on-the-fly compression, it is possible when sending an individual file.
Modification:
Update DataSelection to optionally return the content length.
Update the 'getData' Response to include the
Content-Lengthheader when the request targets a single file that is not placed in a zip archive. If the content is dynamically generated (e.g., a zip file) then noContent-Lengthheader is provided.Result:
IDS now includes the
Content-Lengthresponse header when this is possible