operation::focusable::is_focused & text_input::is_focused
#2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used state of a `focusable` by ID. Add `is_focused` function that produces a `Task` to get the focused state of a `text_input` by ID.
hecrj
requested changes
Feb 22, 2025
| _bounds: Rectangle, | ||
| operate_on_children: &mut dyn FnMut(&mut dyn Operation<bool>), | ||
| ) { | ||
| operate_on_children(self); |
There was a problem hiding this comment.
We could probably stop traversing the widget tree if self.is_focused is already Some:
Suggested change
| operate_on_children(self); | |
| if self.is_focused.is_some() { | |
| return; | |
| } | |
| operate_on_children(self); |
There was a problem hiding this comment.
Thank you for the suggestion! Makes sense to me. Outside the scope of this PR probably, but would it make sense to similarly stop traversing once a result is found for find_focused as well?
There was a problem hiding this comment.
Yes, both nits should apply there as well.
Comment on lines
292
to
293
| if let Some(is_focused) = &self.is_focused { | ||
| Outcome::Some(*is_focused) |
There was a problem hiding this comment.
Since bool is copy, we can avoid the dereference:
Suggested change
| if let Some(is_focused) = &self.is_focused { | |
| Outcome::Some(*is_focused) | |
| if let Some(is_focused) = self.is_focused { | |
| Outcome::Some(is_focused) |
There was a problem hiding this comment.
Maybe even something functional like:
self.is_focused.map_or(Outcome::None, Outcome::Some)There was a problem hiding this comment.
Much cleaner, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two additions:
is_focusedfunction that produces anOperationthat looks for afocusablewidget by ID, and produces aboolthat stores whether the widget is focused or not. This function was modeled after the existingfind_focused, and for my purposes was a means to implement the second addition.is_focusedfunction that produces aTaskthat looks for atext_inputwidget by ID, and produces aboolwith whether the widget is focused or not.Originally I tried to use the
find_focusedOperationfortext_input::is_focused, but I couldn't figure out how to make it work as desired when there is no currently focused widget (andfind_focusedproducesOutcome::None).