Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor improve types and simplified usage #167

Merged
merged 4 commits into from
Aug 14, 2023
Merged

refactor improve types and simplified usage #167

merged 4 commits into from
Aug 14, 2023

Conversation

Redhawk18
Copy link
Contributor

I removed the tuple that the function pointer had, because there was no reason to have it in first place. With that I changed the type of options to a slice &'a [T] making its so many more types can be passed into to widget at creation. Doing that I had to change the required impl's from ToString to Display.

Also I'm considering adding support if the enum has a default, having that default be automatically highlighted. lmk if that's a good idea

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thank you. Originally we had to use Cow for some reason, that I simply can not remember =D or that over time rust itself fixed the issue on the backend.

@genusistimelord genusistimelord merged commit 3625c14 into iced-rs:main Aug 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants