refactor improve types and simplified usage #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the tuple that the function pointer had, because there was no reason to have it in first place. With that I changed the type of
options
to a slice&'a [T]
making its so many more types can be passed into to widget at creation. Doing that I had to change the required impl's fromToString
toDisplay
.Also I'm considering adding support if the enum has a default, having that default be automatically highlighted. lmk if that's a good idea