Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update modal code comments #171

Merged
merged 1 commit into from
Aug 17, 2023
Merged

update modal code comments #171

merged 1 commit into from
Aug 17, 2023

Conversation

lucatrv
Copy link
Contributor

@lucatrv lucatrv commented Aug 17, 2023

No description provided.

genusistimelord
genusistimelord approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. let me know when your done and ill merge it.

@lucatrv
Copy link
Contributor Author

lucatrv commented Aug 17, 2023

As for me it is ready to merge, I am going to add a multiple modal example with a separate PR.

@genusistimelord genusistimelord merged commit 1c3b933 into iced-rs:main Aug 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genusistimelord genusistimelord genusistimelord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucatrv @genusistimelord