Skip to content

Fix bug which caused a lockup when service is deactivated but not destroyed straight away #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icedevml merged 1 commit into from
Jan 28, 2026
Merged

Fix bug which caused a lockup when service is deactivated but not destroyed straight away #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...ages/host-card-emulation/android/src/main/java/com/itsecrnd/rtnhceandroid/HCEService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public class HCEService extends HostApduService implements HCEServiceCallback {
private static final String TAG = "HCEService";

private boolean isForeground;
private volatile boolean isDeactivated;
private String backgroundSessionUUID;
private RTNHCEAndroidModule hceModule;
private byte[] pendingCAPDU;
Expand Down Expand Up @@ -118,6 +119,7 @@ public void onBackgroundHCEFinish(String handle) {
HeadlessJsTaskContext headlessJsTaskContext = Companion.getInstance(reactContext);
headlessJsTaskContext.finishTask(taskId);
taskSessionIdMap.remove(handle);
stopSelf();
}

@Override
Expand All @@ -144,6 +146,11 @@ public void onRespondAPDU(String handle, String rapdu) {
@Override
public byte[] processCommandApdu(byte[] command, Bundle extras) {
Log.d(TAG, "HCEService:processCommandApdu");

if (isDeactivated) {
onCreate();
}

String capdu = BinaryUtils.ByteArrayToHexString(command).toUpperCase(Locale.ROOT);

if (isForeground) {
Expand Down Expand Up @@ -181,6 +188,7 @@ public void onCreate() {
}

isForeground = isAppOnForeground(getApplicationContext());
isDeactivated = false;
pendingCAPDU = null;
hceModule = null;
needsResponse = false;
Expand Down Expand Up @@ -242,6 +250,7 @@ public void onHeadlessJsTaskFinish(int i) {
public void onDeactivated(int reason) {
Log.d(TAG, "HCEService:onDeactivated: " + reason);
needsResponse = false;
isDeactivated = true;

if (isForeground) {
if (this.hceModule != null && this.hceModule.isHCEActiveConnection()) {
Expand Down