Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error in Swift UI helpers when not using moko-resources #269

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix compiler error in Swift UI helpers when not using moko-resources #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions mvvm-flow/apple/xcode/mokoMvvmFlowSwiftUI/ViewModelStateNullable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,6 @@ extension ObservableObject where Self: ViewModel {
mapper: { $0 as? Array<T> }
)
}

func stateNullable(_ flowKey: KeyPath<Self, CStateFlow<StringDesc>>) -> String? {
return stateNullable(
flowKey,
equals: { $0 === $1 },
mapper: { $0?.localized() }
)
}
Comment on lines -99 to -105
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's should not be deleted. it's should be moved to mvvm-flow-resources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I'll make that change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, there isn't a separate mvvm-flow-resources SwiftUI project (something like mokoMvvmFlowResourcesSwiftUI) to move this particular piece of code to.


func stateNullable<T: KotlinBase>(_ flowKey: KeyPath<Self, CStateFlow<T>>) -> T? {
return stateNullable(
Expand Down
Loading