Skip to content

Commit

Permalink
Small cleanup around the term "proxy" (#3824)
Browse files Browse the repository at this point in the history
  • Loading branch information
bernardnormier authored Nov 30, 2023
1 parent 9beca0b commit 2b1e89f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/IceRpc.Slice/PipeReaderExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static IAsyncEnumerable<T> ToAsyncEnumerable<T>(

IEnumerable<T> DecodeBuffer(ReadOnlySequence<byte> buffer)
{
// Since the elements are fixed-size, they can't contain proxies hence serviceProxyFactory can remain null.
// Since the elements are fixed-size, they can't contain service addresses hence baseProxy can remain null.
var decoder = new SliceDecoder(
buffer,
encoding,
Expand Down
2 changes: 1 addition & 1 deletion src/IceRpc.Slice/ServiceAddressSliceDecoderExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ private static ServerAddress DecodeServerAddress(this ref SliceDecoder decoder,
/// <returns>The decoded service address.</returns>
private static ServiceAddress DecodeServiceAddressCore(this ref SliceDecoder decoder, string path)
{
// With Slice1, a proxy is encoded as a kind of discriminated union with:
// With Slice1, a service address is encoded as a kind of discriminated union with:
// - Identity
// - If Identity is not the null identity:
// - the fragment, invocation mode, secure, protocol major and minor, and the encoding major and minor
Expand Down
2 changes: 1 addition & 1 deletion src/IceRpc/Pipeline.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace IceRpc;
/// request over a connection.</summary>
/// <example>
/// The following example demonstrates how an application would typically create the pipeline and use it as the invoker
/// for a proxy.
/// for a Slice proxy or Protobuf client.
/// <code source="../../docfx/examples/IceRpc.Examples/PipelineExamples.cs" region="CreatingAndUsingThePipeline" lang="csharp" />
/// You can easily create your own interceptor and add it to the pipeline. The next example shows how you can create an
/// interceptor using an <see cref="InlineInvoker"/> and add it to the pipeline with
Expand Down

0 comments on commit 2b1e89f

Please sign in to comment.