Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deploy keys #3643

Merged
merged 2 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/actions/build-compiler/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ runs:
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-
- name: 🔗 Start SSH Agent
# With v0.8.0 the clone of icerpc/slicec fails on Windows runners
uses: webfactory/ssh-agent@v0.7.0
with:
ssh-private-key: ${{ env.SLICEC_DEPLOY_KEY }}
- name: Install Cross Tools
if: ${{ inputs.target == 'aarch64-unknown-linux-gnu' }}
run: sudo apt install gcc-aarch64-linux-gnu binutils-aarch64-linux-gnu --yes
Expand All @@ -41,7 +36,6 @@ runs:
targets: ${{ inputs.target }}
- name: Build Slice Compiler
env:
CARGO_NET_GIT_FETCH_WITH_CLI: true
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
run: |
cargo build --manifest-path tools/slicec-cs/Cargo.toml ${{ inputs.cargo-build-args }} --target ${{ inputs.target }}
Expand Down
6 changes: 0 additions & 6 deletions .github/actions/build/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,11 @@ runs:
sudo apt install libmsquic
shell: bash
if: runner.os == 'Linux'
- name: 🔗 Start SSH Agent
uses: webfactory/ssh-agent@v0.7.0
with:
ssh-private-key: ${{ env.SLICEC_DEPLOY_KEY }}
- name: Rust toolchain
uses: dtolnay/rust-toolchain@stable
- name: 🔨 Build Slice Compiler
run: |
cargo build --manifest-path tools/slicec-cs/Cargo.toml ${{ inputs.cargo-build-args }}
env:
CARGO_NET_GIT_FETCH_WITH_CLI: true
shell: bash
- name: 🔨 Build IceRPC Slice Tools
working-directory: tools/IceRpc.Slice.Tools
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ jobs:
uses: actions/checkout@v3
- name: Build
uses: ./.github/actions/build
env:
SLICEC_DEPLOY_KEY: ${{ secrets.SLICEC_DEPLOY_KEY }}
NUGET_API_TOKEN: ${{ secrets.NUGET_API_TOKEN }}
- name: Publish
uses: ./.github/actions/publish
- name: Build Examples
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ jobs:
with:
cargo-build-args: --release
target: ${{ matrix.target }}
env:
# TODO remove once slicec repository is public
SLICEC_DEPLOY_KEY: ${{ secrets.SLICEC_DEPLOY_KEY }}
- name: Archive Build
uses: actions/upload-artifact@v3
with:
Expand Down
15 changes: 0 additions & 15 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,21 +82,6 @@ This command builds slicec-cs, all the IceRpc assemblies, and the IceRpc tests w

The -build/--build action is optional since it's the default build action.

> **Note** TODO: remove once the repository is public
>
> The build system for the slicec-cs compiler fetches the slicec library from the slicec repository. If the build fails
> to fetch slicec with a permission denied error, set the following environment variable:
>
> Linux or macOS
> ```shell
> export CARGO_NET_GIT_FETCH_WITH_CLI=true
> ```
>
> Windows
> ```shell
> set CARGO_NET_GIT_FETCH_WITH_CLI=true
> ```

### Visual Studio Code

Select `Tasks: Run Build Task...` from the command palette to run the build script from Visual Studio Code.
Expand Down
Loading