Fix encoding of optional custom types #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
pepone,
externl and
InsertCreativityHere
bernardnormier
commented
Nov 30, 2023
tools/slicec-cs/src/encoding.rs
Outdated
| let value = match (is_optional, type_ref.is_value_type()) { | ||
| (true, false) => "value!", | ||
| (true, true) => "value!.Value", | ||
| let value = match (is_optional, type_ref.is_value_type(), type_ref.is_reference_type()) { |
There was a problem hiding this comment.
I didn't change the logic of this code in this PR, even though it's definitely inelegant.
We compute this value here and then use "value" or value in the code below, which is pretty confusing. Not having any comment doesn't help either.
There was a problem hiding this comment.
Yes, definitely inelegant.
InsertCreativityHere
approved these changes
Nov 30, 2023
tools/slicec-cs/src/encoding.rs
Outdated
| let value = match (is_optional, type_ref.is_value_type()) { | ||
| (true, false) => "value!", | ||
| (true, true) => "value!.Value", | ||
| let value = match (is_optional, type_ref.is_value_type(), type_ref.is_reference_type()) { |
There was a problem hiding this comment.
Yes, definitely inelegant.
pepone
approved these changes
Nov 30, 2023
Co-authored-by: Jose <pepone@users.noreply.github.com>
pepone
approved these changes
Nov 30, 2023
externl
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3812.