Make IProxy.Invoker not nullable #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Dec 1, 2023
src/IceRpc.Slice/IProxy.cs
Outdated
| @@ -1,5 +1,7 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
|
|
|||
| using System.ComponentModel.DataAnnotations; | |||
There was a problem hiding this comment.
Not sure how this using was added. Will remove.
pepone
reviewed
Dec 1, 2023
|
|
||
| /// <inheritdoc/> | ||
| public IceRpc.IInvoker? Invoker {{ get; init; }} = null; | ||
| public required IceRpc.IInvoker Invoker {{ get; init; }} |
There was a problem hiding this comment.
We should do the same for the Protobuf client
externl
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes IProxy.Invoker not nullable, just like IProtobufClient.Incoker.
Rather than null, the code now uses InvalidInvoker.Instance when it needs an invalid invoker - typically when the proxy is used for encoding and not for invoking.