Use github.ref_name instead of hardcoded branch name #4085
Conversation
.github/workflows/coverage.yml
Outdated
| env: | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| AWS_DEFAULT_REGION: us-east-1 | ||
| if: github.ref == 'refs/heads/main' && github.event_name != 'pull_request' | ||
| if: github.event_name != 'pull_request' |
There was a problem hiding this comment.
We only run the workflow on push or prs on the branch specified at the top of the file, so I think we really only need to check that it's not a PR.
There was a problem hiding this comment.
What is the event_name that triggers the build when you push to an open PR?
There was a problem hiding this comment.
Why no if: github.event_name == 'push' it makes clear we are only interested in push events.
There was a problem hiding this comment.
The original version I found on stack overflow. I think the original intention for using != 'pull_request' is that you could trigger the workflow manually if enabled (if configured).
There was a problem hiding this comment.
What is the
event_namethat triggers the build when you push to an open PR?
Not sure, I suspect still pull_request
This PR updates the coverage and doc workflows to use
github.ref_nameinstead of a hard coded branch name for the s3 path.This way there's nothing to update in this part of the workflows when we create a new branch of off
main.