Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony integration #652

Open
wants to merge 12 commits into
base: harmony-take2
Choose a base branch
from

Conversation

betolink
Copy link
Contributor

@betolink betolink commented Feb 4, 2025

This PR will integrate Harmony functionality to the Query class, it breaks the query file into base_query and the query itself. Right now it's a draft and WIP. I still need to implement full CMR parameters in the Harmony query call to be able to use cycles and tracks.

pre-commit-ci bot and others added 3 commits December 2, 2024 18:59
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Feb 4, 2025

Binder 👈 Launch a binder notebook on this branch for commit 0158168

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit ddab53b

Binder 👈 Launch a binder notebook on this branch for commit 4e93ab6

Binder 👈 Launch a binder notebook on this branch for commit cce5f26

Binder 👈 Launch a binder notebook on this branch for commit 09ff7ea

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@betolink betolink marked this pull request as ready for review February 14, 2025 19:38
@betolink
Copy link
Contributor Author

I think we can start reviewing the changes, @JessicaS11 @asteiker some tests fail because they need the secrets from the repo to be injected as credentials, once merged into icepyx they should pass, they pass locally if we export EARTHDATA_USERNAME and EARTHDATA_PASSWORD.

This PR wires Icepyx to harmony, the 2 notebooks I used for reference are the one that subsets data and the one that access the data. I fixed a few things along the way and will write more comments on Monday.

@betolink betolink requested a review from JessicaS11 February 14, 2025 20:19
@betolink
Copy link
Contributor Author

I just noticed that we may need to merge Wei Ji's branch, I dropped python 3.9 in favor of 3.10 and his branch goes to 3.11 which is better and I missed some files too.

@@ -165,7 +165,7 @@ See this thread on EOSDIS Slack for more details:

## Remaining tasks

Remaining tasks for "take2" development incldue:
Remaining tasks for "take2" development includue:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha still a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant