Add support for Scaleway compute instances#11
Open
srd424 wants to merge 2 commits intoicetan:masterfrom
Open
Conversation
This is a little messy, we need to unmount e.g. /boot/efi in Ubuntu in order to move /boot out of the way, but we need to remount the ESP so we can successfully install a bootloader. I've tried to make this as generic as possible, it checks an EFI variable to see where we booted from first, and if that doesn't work it will fall back to checking what is mounted on /boot/efi.
Rather than use hardwired partition numbers for the ESP, use the label on the assumption that it might be a little less brittle. We could alternatively come up with a way to duplicate the ESP-finding code from the previous commit, but this is simplest for now.
Owner
|
Sorry for late reply! This looks great, thank you. Will try this out. I have been looking a bit at the https://github.com/nix-community/nixos-anywhere project and been thinking if it could be integrated into Just FYI, there is also some vague plans to rewrite |
Author
|
Hah, I'm old enough that piles of bash are kind of my forté - at least, I do better with them than piles of golang or rust :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves adding some generic UEFI support first.
I've still got an error on push:
But I think this is possibly due to nixiform's existing logic becoming out of step with modern NixOS - it seems to run
switch-to-configuration bootand thenswitch-to-configuration switch, and it's the latter that's breaking. Manual reboot seems to result in a working system anyway - I'm not sure we need the second invocation?Opening this PR anyway as I've got go work on other things now and I thought this might be useful.