Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Create Load Config For Server #45

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

mbsaloka
Copy link
Contributor

Jira Link:

Description

Added a service to load configuration to the server when a button in the app is pressed.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@mbsaloka mbsaloka changed the title [Enhancement] Create Load Config For Sever [Enhancement] Create Load Config For Server Jun 11, 2024
@@ -0,0 +1,45 @@
// Copyright (c) 2023 Ichiro ITS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@@ -0,0 +1,57 @@
// Copyright (c) 2023 Ichiro ITS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines 23 to 24
#include "rclcpp/rclcpp.hpp"
#include "nlohmann/json.hpp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nlohmann before rclcpp

@mbsaloka mbsaloka merged commit 26a6923 into master Jun 15, 2024
1 check failed
@mbsaloka mbsaloka deleted the enhancement/load-config-for-server branch June 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants