Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update Github Workflows #65

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

marfanr
Copy link
Contributor

@marfanr marfanr commented Aug 27, 2024

Jira Link:

Description

update dependency on github actions and add discord-pr-bot

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/dispatch-discord-pr-bot.yml Outdated Show resolved Hide resolved
@threeal
Copy link
Member

threeal commented Aug 28, 2024

Since the test is failing due to issues with the Jitsuyo and Keisan packages, could you fix those packages first before merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants