Improvement: Update defs id's inside style attribute when needed#56
Open
jjdive wants to merge 1 commit intoiconic:masterfrom
jjdive:improve-defsids-inside-style-attr
Open
Improvement: Update defs id's inside style attribute when needed#56jjdive wants to merge 1 commit intoiconic:masterfrom jjdive:improve-defsids-inside-style-attr
jjdive wants to merge 1 commit intoiconic:masterfrom
jjdive:improve-defsids-inside-style-attr
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use inkscape to generate some svg's. It includes de linearGradient and other properties inside the style attribute of the path elements so the id's of those definitions should also be updated to maintain the references.
The piece of code i'm adding, just search for the property name inside the style attribute and tries to replace the link with the newId that has an 'injectCount' suffix.