Navigate visible history #3591
Navigate visible history #3591
Conversation
|
Why do we need a |
|
Because it differs from what is in the tree, it shows full types, members including type, and assembly name for some of the folders (screenshot first item) |
|
I can also imagine it could be a method where you put current state and the text would differ on where you are (like same namespace or same assembly) |
|
I think I am fine with that. Does need to be in the |
|
It's also important to use the settings-aware implementation for the node text that is used everywhere else. |
|
It has a default implementation returning You can see in the changed files that it follows what With that said, I don't mind using |
|
Maybe put the folder in parentheses? I am not sure. I can have a closer look when I get home. Reviewing code on the phone is not ideal. 😅 |
|
I put the folder first and where it belongs in parentheses, looks better, see the updated screenshot. |
|
I also tried to include module name in the metadata nodes but feel free to skip that commit. Done working on this PR until there is feedback to address. |
|
One thought I had: is it possible to get an actual dropdown toolbar button in WPF? Is this only included in some community library? |
|
There is no built-in dropdown button in WPF. I considered creating a control for it (or retemplating combobox) but since the theme and styles are external it didn't seem worth it. We could also just have it as context menu on the normal buttons and that's it. |
| : metadata.GetString(metadata.GetModuleDefinition().Name); | ||
| if (metadata.IsAssembly) | ||
| value = metadata.GetString(metadata.GetAssemblyDefinition().Name); | ||
| else if (metadata.DebugMetadataHeader == null) // standalone debug metadata does not contain module table |
There was a problem hiding this comment.
probably should check Kind instead?
There was a problem hiding this comment.
The GetModuleDefinition throws on non-null DebugMetadataHeader, so that felt like an appropriate check before invoking it.
I don't mind changing it to Kind check, but I would need some hint about which Kinds guarantee DebugMetadataHeader, as I don't know how to produce e.g. WebCIL to check.
|
I am playing around with your PR and something I noticed: 
this doesn't seem to be very useful... I think each item should include the top-level ancestor, maybe? |
|
Yeah I am aware of that. I thought it is a rare if not adverse scenario where you would jump through the same nodes in different assemblies. I thought about adding the top-level info, but then all the items become cluttered with full assembly name for minimal benefit in rare cases. Next thing you come with will be same assembly names using different file locations, so I think the line needs to be drawn somewhere. This is not intended to replace user's memory. You still know what you have been doing recently so you will have an idea where the items come from. With that said, with the I could also do some analysis when building the history list, and if the previous item "looks the same" but has different top level, append the top level. |
|
You are right. It's probably fine the way it's now. |
3 participants
Implements #3582 to show history items:
@aybe