-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an ab initio parse method. #595
base: alpha-test-dev
Are you sure you want to change the base?
Conversation
Also an open question is: if this should ship for 0.6 or 1.0 |
To document pretty_str or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to monkey around with this some on some complex models and see if I can break it.
Here are some comments in the meanwhile.
Overall from a UX perspective, do you like it @tjlaboss? |
Yes, at first glance, but I want to experiment with it on a practical case. |
Also keep in mind this is merging into alpha-test and not dev. So trying it out can be part of alpha testing. |
I deleted the tests from #597. I think the testing from |
Description
This feature adds the ability to parse MCNP inputs arbitrarily. All
MCNP_Object
now accepts and parsesstr
. This also introducesMCNP_Problem.parse
which is a convenience function that just parses, and goes. This also adds the ability to pass a number to a constructor to simplify the build.Fixes #88
Checklist