Implement std::error::Error for easier error handling #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
thread_priority::Error
type does not implement Rust's standard error trait,std::error::Error
. This means that user code cannot use the?
operator in certain contexts. Examples include when using theanyhow
error handling library or as part of a function that is generic over the type of error that may be returned (Box<dyn std::error::Error>
). Some Rust libraries and developers may expect that types representing errors will implementstd::error::Error
.This PR adds the trait implementation so that
thread_priority::Error
integrates more readily with the rest of the Rust ecosystem.As a demonstration, I also refactored the
should_be_possible_to_reset_the_same_priority()
unit test to work with the?
operator. The code in the new unit test was a compile error untilstd::error::Error
was implemented.