warn about Ruby 3 incompatibility. #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrunner
approved these changes
Aug 1, 2023
saikumar9
changed the title
|
This ticket has been made obsolete by #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently event source uses several methods that were deprecated (particularly on URI) in Ruby 2.7 and removed entirely in Ruby 3. As a result, we should prevent the installation of event_source into Ruby 3 projects until the issue is corrected.
Furthermore, we should create a matrix testing run for various ruby versions when we correct the issue, so the event source tests will be executed against a variety of Ruby versions and issues like this will be spotted in the future.