Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate linked multi query #84

Merged
merged 1 commit into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ const (
ErrorEmptyChallenge = "empty challenge"
ErrorEmptyGISTProof = "empty GIST identity mtp proof"
ErrorEmptyRequestID = "empty request ID"
ErrorEmptyLinkNonce = "empty link nonce"
ErrorEmptyClaim = "empty claim"
ErrorEmptyQueries = "empty queries"
ErrorTooManyQueries = "too many queries"
ErrorInvalidProofType = "invalid proof type"
ErrorEmptySignatureProof = "empty signature proof"
ErrorEmptyMTPProof = "empty MTP proof"
Expand Down
34 changes: 34 additions & 0 deletions linkedMultiQuery.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (

core "github.com/iden3/go-iden3-core/v2"
"github.com/iden3/go-merkletree-sql/v2"
"github.com/pkg/errors"
)

const LinkedMultiQueryLength = 10
Expand Down Expand Up @@ -37,8 +38,41 @@ type linkedMultiQueryCircuitInputs struct {
ActualValueArraySize []int `json:"valueArraySize"`
}

func (l LinkedMultiQueryInputs) Validate() error {
if l.LinkNonce == nil {
return errors.New(ErrorEmptyLinkNonce)
}

if l.Claim == nil {
return errors.New(ErrorEmptyClaim)
}

if len(l.Query) == 0 {
return errors.New(ErrorEmptyQueries)
}

if len(l.Query) > LinkedMultiQueryLength {
return errors.New(ErrorTooManyQueries)
}

for _, q := range l.Query {
if q == nil {
continue
}
if err := q.ValidateValueArraySize(l.GetValueArrSize()); err != nil {
return err
}
}

return nil
}

// InputsMarshal returns Circom private inputs for linkedMultiQuery10.circom
func (l LinkedMultiQueryInputs) InputsMarshal() ([]byte, error) {
if err := l.Validate(); err != nil {
return nil, err
}

s := linkedMultiQueryCircuitInputs{}
s.LinkNonce = l.LinkNonce.String()
s.IssuerClaim = l.Claim
Expand Down
47 changes: 47 additions & 0 deletions linkedMultiQuery_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,53 @@ func TestLinkedMultiQueryInputs_PrepareInputs_Ln(t *testing.T) {
require.JSONEq(t, exp, string(bytesInputs))
}

func TestLinkedMultiQueryInputs_PrepareInputs_Error(t *testing.T) {
user := it.NewIdentity(t, userPK)
subjectID := user.ID
claim := it.DefaultUserClaim(t, subjectID)
in := LinkedMultiQueryInputs{
//LinkNonce: big.NewInt(35346346369657418),
//Claim: claim,
}
_, err := in.InputsMarshal()
require.EqualError(t, err, "empty link nonce")

in.LinkNonce = big.NewInt(35346346369657418)
_, err = in.InputsMarshal()
require.EqualError(t, err, "empty claim")

in.Claim = claim
_, err = in.InputsMarshal()
require.EqualError(t, err, "empty queries")

in.Query = append(in.Query,
&Query{
ValueProof: nil,
Operator: EQ,
Values: []*big.Int{big.NewInt(10)},
SlotIndex: 2,
},
&Query{
ValueProof: nil,
Operator: LT,
Values: []*big.Int{big.NewInt(133)},
SlotIndex: 2,
},
&Query{
ValueProof: nil,
Operator: LTE,
Values: []*big.Int{big.NewInt(555)},
SlotIndex: 2,
},
)

bytesInputs, err := in.InputsMarshal()
require.NoError(t, err)

exp := it.TestData(t, "linkedMultiQuery_inputs", string(bytesInputs), *generate)
require.JSONEq(t, exp, string(bytesInputs))
}

func TestLinkedMultiQueryPubSignals_CircuitUnmarshal(t *testing.T) {
out := new(LinkedMultiQueryPubSignals)
err := out.PubSignalsUnmarshal([]byte(
Expand Down
Loading