Feat/remove-authV3-8-32 #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_32Circuit and related instances. Update witnessBuilder function parameter type for consistency. Clean up jwz tests by removing deprecated tests for AuthV3_8_32. This streamlines the proving methods and enhances code clarity.
There was a problem hiding this comment.
Pull request overview
This PR removes support for the authV3-8-32 circuit variant from the js-jwz library. The removal includes eliminating the circuit constant, proving method instance, related exports, and test suite. The PR also includes two additional changes to the codebase: narrowing the type parameter of the witnessBuilder function from BufferSource to ArrayBuffer, and updating references to the bn254 curve API.
- Removes all authV3-8-32 circuit-related code and exports
- Updates
witnessBuilderparameter type fromBufferSourcetoArrayBuffer - Updates bn254 curve API references from
bn254.G1.ProjectivePointtobn254.curves.G1 - Bumps version from 1.12.2 to 1.13.0
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/jwz.test.ts | Removes the entire authV3_8_32-Groth16 test suite (64 lines) |
| src/witness_calculator.ts | Narrows function parameter type from BufferSource to ArrayBuffer |
| src/index.ts | Removes authV3_8_32 proving method import, registration, and export |
| src/common.ts | Removes AuthV3_8_32Circuit constant, adds type cast for ArrayBuffer, updates bn254 curve API |
| src/authV3Groth16.ts | Removes AuthV3_8_32Groth16Alg and provingMethodGroth16AuthV3_8_32Instance |
| package.json | Bumps version to 1.13.0 |
| package-lock.json | Updates version references to match package.json |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nsolidate test cases for dynamicProve and dynamicVerify, and adjust timeout settings for better performance.
…. Refactor dynamic proof tests for improved readability and structure, consolidating test cases for dynamicProve and dynamicVerify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.