-
Notifications
You must be signed in to change notification settings - Fork 14
Audio pipeline dependencies are reduced, bug fixed, room acoustics made more tunable and demo improved #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qanastek
wants to merge
125
commits into
idiap:main
Choose a base branch
from
qanastek:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e jupyter notebook.
…on pipeline in the jupyter notebook
- Clean pavel fuction header. - Add datasets as a dependency
Bug found: Do not merge |
…bout age and genre of the personas.
- Update the tutorial notebooks to make them cleaner
- Add voice control during inference, the user can provide either: a voice name for each speaker, a voice object or nothing (in order to trigger the automatic selection of the voice). - Voices attributed during inference can now be unique or not by setting up the parameter `keep_duplicate`. - Updated the tutorial 8 to show the new features.
…rable - Link Dialog to_audio with utils one using **kwargs - Test the tutorials
- Add a mode for microphone position to be centered in the x / y axis between speakers 1 and 2
- Compute directivity toward speakers (1 or 2) - Handle directivity in the case of ray tracing (can only handle onmi) - Provide parameters to define a custom directivity to the microphone - Test as much scenarios as possible
- Rename tutorials
…convention - Run and save all the tutorials outputs in the notebooks - Add a example without any parameters
…d 3D based on user preferences
- Improve logging - Clear logs from notebooks (too big for github) - Remove TODOs tags
…xt (not tested yet)
- Download the json file if not available locally (exlusive run of the notebook or on colab - Remove download from ollama on audio tutorials since not needed
…equired functions in order to be accessible from the users.
…ndering only of the step 3 - Fix center of the room position x and y axis - Add method to change the position of the microphone after the initialization of the room object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.