-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ieee 269 create table for orders page #500
Conversation
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
@@ -86,7 +88,8 @@ const Orders = () => { | |||
</Grid> | |||
<Grid item lg={12}> | |||
<Grid container spacing={1} direction="row"> | |||
{allOrders.map((order, idx) => ( | |||
<OrdersTable ordersData={mockPendingOrders} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used mockPendingOrders for now, but will later be replaced with allOrders
from redux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natapokie The github actions do work now :) The test cases fail for the |
in recent commit, 6108852, i commented testcases for the OrderCard and related components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Natalie, overall great work! This is close to merging, but I have made some minor comments. I think there are some tests missing for the OrdersTable component. We should ensure that the component displays data accurately, handles row double-click events, and calculates the order quantity correctly using the valueGetter function. If you have any questions on how we can do that, let me know :)
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey I requested some really minor changes, other than should be good to go
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.test.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
hackathon_site/dashboard/frontend/src/components/orders/OrdersTable/OrdersTable.tsx
Outdated
Show resolved
Hide resolved
Hi @natapokie this lgtm, I just have on style comment, can we make the color of the orders table white, cause I think it blends too much with the background. What do you think? |
…b.com/ieeeuoft/hackathon-template into IEEE-269-create-table-for-orders-page
yep I agree! i didn't notice the coloring due to my display settings, it's changed to white now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Overview
Resolves 269
Created a table for the orders instead of order cards which also includes status
Order
type (note: tables takes in a prop of typeOrders
so it can be used with Redux later)I also left some comments in the code, if there were better ways to do certain things to prevent the spaghetti code
Unit Tests Created
Steps to QA
Order[]