Ieee 259 add description box on teams homepage #509

KarandeepLubana · 2023-09-11T01:35:25Z

Overview

Resolves #IEEE259
Added an input box on the team's home page to describe what their project is

Unit Tests Created

Tests were created to verify that the Redux store updates correctly with the new project_description after dispatching the updateProjectDescription thunk.

Steps to QA

Navigate to the dashboard page
There should be a textbox with text saying "Write your project description here"

…submit button

…b.com/ieeeuoft/hackathon-template into IEEE-272-implement-item-incident-form

…it to pass more info about hardware for incident form

… don't submit the form

…epage

Mustaballer

Great job @KarandeepLubana! This is looking close to merging, I have left some minor comments.

Mustaballer · 2023-09-12T17:40:09Z

..._site/dashboard/frontend/src/components/teamDetail/ProjectDescription/ProjectDescription.tsx

+                    projectDescription: values.projectDescription,
+                })
+            );
+        } catch (error) {


you should probably throw an error snackbar in case of an error, and also make a unit test for this snackbar

actually is it necessary to have this try and catch block here? Doesn't the thunk already handle the asynchronous logic?

Yeah, I believe it's not necessary

Mustaballer · 2023-09-12T17:43:03Z

..._site/dashboard/frontend/src/components/teamDetail/ProjectDescription/ProjectDescription.tsx

+                            variant="outlined"
+                            disabled={!isEditing}
+                            rows={4}
+                            style={{ margin: "20px 5px 0 0" }}


can you put the styling in this file in ProjectDescription.module.scss. Reminder for scss you need to compile in order for the css to show, refer to README.md on how to do that.

Mustaballer · 2023-09-12T17:43:24Z

..._site/dashboard/frontend/src/components/teamDetail/ProjectDescription/ProjectDescription.tsx

+                                            type="submit"
+                                            variant="contained"
+                                            disabled={!isValid || isSubmitting}
+                                            style={{


put in ProjectDescription.module.scss

Mustaballer · 2023-09-12T17:43:42Z

..._site/dashboard/frontend/src/components/teamDetail/ProjectDescription/ProjectDescription.tsx

+                                            type="button"
+                                            variant="contained"
+                                            color="secondary"
+                                            style={{ width: "120px" }}


put in ProjectDescription.module.scss

Mustaballer · 2023-09-12T17:43:52Z

..._site/dashboard/frontend/src/components/teamDetail/ProjectDescription/ProjectDescription.tsx

+                                        type="button"
+                                        variant="contained"
+                                        color="primary"
+                                        style={{ width: "120px" }}


put in ProjectDescription.module.scss

Mustaballer · 2023-09-12T17:45:20Z

hackathon_site/dashboard/frontend/src/pages/Dashboard/Dashboard.tsx

@@ -122,6 +123,9 @@ const Dashboard = () => {
                        {fetchOrderError && <AlertBox error={fetchOrderError} />}
                        {/* TODO: add back in when incident reports are completed on the frontend */}
                        {/* <BrokenTable items={itemsBroken} openReportAlert={openBrokenTable} /> */}
+                        <ProjectDescription


You could do <ProjectDescription teamCode={team_code ?? "None"} /> to make it cleaner

…epage

Mustaballer · 2024-01-16T02:41:35Z

@KarandeepLubana This looks fantastic! I'd like to suggest a small enhancement: we should prevent teams from submitting orders on the cart page unless they have provided a project description. Perhaps we could implement an error message in the project description section, particularly if the description is too brief (consider using a predefined constant for the minimum length). You can modify CartSummary.tsx to include a reminder or guideline about writing a project description or in any other files you think makes sense. If you need any clarification, feel free to ask!

Edit: Please also add the project description to TeamDetail.tsx so admin users can view the project description when they click on a teams detail page.

Edit: You can add an alert suggesting that users need to add a project description like in DateRestrictionAlert.tsx

Mustaballer · 2024-01-28T20:18:43Z

hackathon_site/event/api_views.py

@@ -283,7 +283,6 @@ class TeamDetailView(
    generics.GenericAPIView,
 ):
    serializer_class = TeamSerializer
-    permission_classes = [FullDjangoModelPermissions]


is this necessary to remove, i think thats why the backend checks are failing

…epage

Mustaballer · 2024-02-01T03:28:18Z

Great work, pls copy the changes over to the makeuoft repo as well!

natapokie and others added 30 commits June 15, 2023 23:39

incident form init

7675935

implementing form components

fbcd75a

fixing form style

dcfc142

fixing position of menu items

e99f1bd

implement back button

dccfb73

adding helper text for radio

5b0f2a7

fixing button

e6e2728

cleaning up unused vars

59d63f8

adding report broken lost button

11ffa1d

init test

c7efa0e

fixing link

9649eaa

reset form on successful submission

c195a9f

setting up testing

05213d4

fix test

a4207bb

fixing tests

675226e

removing unused code

3b36389

adding name to readme

7a96957

fix type error

4e0baf4

padding qty to new page & adding snackbar

c4180b8

rewriting formik with map

14b8638

fixing responsive issues on form

ee0039f

fixing checkedout tables style

59f3793

adding map to radio options

ae22fc6

using map in form

94e74a5

fixing textfield width

617cb3f

fixing validation onchange

d589a3a

Merge branch 'develop' into IEEE-272-implement-item-incident-form

6a36f5f

Merge branch 'develop' into IEEE-272-implement-item-incident-form

eeee0ee

adding more unit tests to check for rendering of form components and …

c84c303

…submit button

Merge branch 'IEEE-272-implement-item-incident-form' of https://githu…

84661aa

…b.com/ieeeuoft/hackathon-template into IEEE-272-implement-item-incident-form

natapokie and others added 8 commits July 12, 2023 21:48

adding more padding between form elements and labels

7f1cd4f

removing inline styles (sorry bad habitsgit status)

09a135b

removing unused code and console.log & changing url format a little b…

98b8f1f

…it to pass more info about hardware for incident form

added yup validation to check if the input string is 0 for qty, is so…

a9308ec

… don't submit the form

IEEE-259 add input box on teams homepage

c7aaf9a

Delete hackathon_site/dashboard/frontend/package-lock.json

497cbad

Merge branch 'develop' into IEEE-259-add-description-box-on-teams-hom…

183ec38

…epage

IEEE-259 remove unused ErrorMessage

d49aef8

Mustaballer requested changes Sep 12, 2023

View reviewed changes

Mustaballer and others added 2 commits October 22, 2023 20:04

Merge branch 'develop' into IEEE-259-add-description-box-on-teams-hom…

7e3c9fc

…epage

IEEE-259 refactor and clean project description component

092f172

KarandeepLubana requested a review from Mustaballer January 16, 2024 02:27

Merge branch 'develop' into IEEE-259-add-description-box-on-teams-hom…

aa3b498

…epage

Karandeep Lubana added 3 commits January 27, 2024 19:21

IEEE-259 Add title and project description to admin page

69e0f65

IEEE-259 Clean code in CartSummary.tsx

094bacc

IEEE-259 Add project description character limit display and fix tests

b8755ba

Mustaballer reviewed Jan 28, 2024

View reviewed changes

Karandeep Lubana added 2 commits January 29, 2024 23:18

IEEE-259 refactor project description component and teamDetail slice

7db2858

IEEE-259 Fix dashboard and teamDetails test cases

7d20e6e

KarandeepLubana requested a review from Mustaballer February 1, 2024 02:54

Merge branch 'develop' into IEEE-259-add-description-box-on-teams-hom…

c3eff7b

…epage

Mustaballer approved these changes Feb 1, 2024

View reviewed changes

thomaslin2020 approved these changes Feb 1, 2024

View reviewed changes

Mustaballer merged commit 4585976 into develop Feb 1, 2024
3 checks passed

Mustaballer deleted the IEEE-259-add-description-box-on-teams-homepage branch February 1, 2024 15:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ieee 259 add description box on teams homepage #509

Ieee 259 add description box on teams homepage #509

KarandeepLubana commented Sep 11, 2023

Mustaballer left a comment

Mustaballer Sep 12, 2023

Mustaballer Sep 14, 2023

KarandeepLubana Jan 16, 2024

Mustaballer Sep 12, 2023

Mustaballer Sep 12, 2023

Mustaballer Sep 12, 2023

Mustaballer Sep 12, 2023

Mustaballer Sep 12, 2023

Mustaballer commented Jan 16, 2024 •

edited

Loading

Mustaballer Jan 28, 2024

Mustaballer commented Feb 1, 2024

Ieee 259 add description box on teams homepage #509

Ieee 259 add description box on teams homepage #509

Conversation

KarandeepLubana commented Sep 11, 2023

Overview

Unit Tests Created

Steps to QA

Mustaballer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mustaballer commented Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

Mustaballer commented Feb 1, 2024

Mustaballer commented Jan 16, 2024 •

edited

Loading