feat: author's address section title misuses possessive mark or uses a character other than a single quote #72
+82
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Dmutre
commented
Feb 5, 2025
Dmutre
commented
- added new validation
- fixed tests and validation due to new parsing
…ssessive mark or uses a character other than a single quote" - modified validation function - modified txt parser, now it add section header - changed test data, due to new parser and validations - changed validation condition for empty section checking
rjsparks
reviewed
Feb 6, 2025
rjsparks
reviewed
Feb 6, 2025
rjsparks
requested changes
Feb 6, 2025
rjsparks
previously approved these changes
Feb 21, 2025
…ssessive-mark-or-uses-a-character-other-than-a-single-quote
NGPixel
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.