Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CBOR Headers and Serialization #140

Merged
merged 12 commits into from
Oct 20, 2024
Merged

Adding CBOR Headers and Serialization #140

merged 12 commits into from
Oct 20, 2024

Conversation

dwaite
Copy link
Collaborator

@dwaite dwaite commented Oct 18, 2024

First pass at what might be considered "proper" CBOR support.

Incomplete list of tasks:

  • Algorithms registry to take into account numerical algorithm identifiers in CBOR
  • Nonce resolution due to rules added by EATS - do we keep the very different format requirements or adopt one/the other.
  • Additional editorial pass on the proof document
  • Align changes on each document
  • Change proof_jwk to proof_key and presentation_jwk to presentation_key (see: Change Issued JWK / Presented JWK Protected Headers #142 )
  • Change "The compact serialiation provides a space-efficient encoding" to "The compact serialization provides a JSON-based space-efficient encoding".
  • Add the missing IANA.MediaTypes reference.

Goal is to get this shared in advance for discussion/revision during 121. One overarching question is whether we try to further consolidate to have the headers have a consistent data model and rules, even if that means further deviating from JOSE rules for the similarly-named headers.

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply my change suggestions, then I'll approve.

Let's also change proof_jwk to proof_key and presentation_jwk to presentation_key throughout because it's odd having _jwk named things referring to COSE_Key objects.

Please change "The compact serialiation provides a space-efficient encoding" to "The compact serialization provides a JSON-based space-efficient encoding".

Please add the missing IANA.MediaTypes reference.

dwaite and others added 3 commits October 19, 2024 17:41
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
dwaite and others added 8 commits October 19, 2024 17:42
@selfissued selfissued merged commit cbf9c4f into main Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants