-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CBOR Headers and Serialization #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply my change suggestions, then I'll approve.
Let's also change proof_jwk
to proof_key
and presentation_jwk
to presentation_key
throughout because it's odd having _jwk named things referring to COSE_Key objects.
Please change "The compact serialiation provides a space-efficient encoding" to "The compact serialization provides a JSON-based space-efficient encoding".
Please add the missing IANA.MediaTypes reference.
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
First pass at what might be considered "proper" CBOR support.
Incomplete list of tasks:
proof_jwk
toproof_key
andpresentation_jwk
topresentation_key
(see: Change Issued JWK / Presented JWK Protected Headers #142 )Goal is to get this shared in advance for discussion/revision during 121. One overarching question is whether we try to further consolidate to have the headers have a consistent data model and rules, even if that means further deviating from JOSE rules for the similarly-named headers.