-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package.json with aasvg #142
Conversation
Thanks for the contribution. I actually completed the supporting work, with package.json and other requirements, and it works partly. The SVG can be output by the CLI but Mermaid itself makes not-so-standard SVG files and fails tests later in the pipeline. That's why I voluntarily closed #134. More details there. In the coming weeks I am more than happy to work with you on determining how hard it is to make upstream fixes to Mermaid but it won't be trivial. EDIT: People wisely told me I am being silly and this is a very different issue and I conflated two. That's very correct! Easy to test and review PR, apologies, @thgoebel. |
I cloned fresh, and ran make, and I see several errors on the main branch... including this one.
This PR should be merged, and the other errors should be addressed before other PRs are accepted. |
Yeah I am confused as when working on previous PRs, I only knew things were not working because I got errors from SVGs rendered from |
The majority of other drafts I viewed didn't include package.json, which does require additional setup for the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As suggested in martinthomson/i-d-template#385 (comment), there should be a
package.json
. Then runningmake
will automatically install aasvg (assuming that npm is installed, which I am documenting in martinthomson/i-d-template#419).Without this (and without aasvg installed otherwise), running
make
will throw an error: