Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normative language for error code per #25 #37

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

aj-stein
Copy link
Contributor

@aj-stein aj-stein commented Nov 2, 2024

No description provided.

@aj-stein aj-stein marked this pull request as ready for review November 2, 2024 13:06
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had decided to make this change locally on my live branch too :-)

Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aj-stein aj-stein marked this pull request as draft November 10, 2024 22:54
@aj-stein
Copy link
Contributor Author

I know the PR change was ostensibly made locally by @JAG-UK, but if possible if you will use this I would like to hold off for now. I am sure we have plenty of time. Thanks for the consideration!

@aj-stein aj-stein marked this pull request as ready for review November 19, 2024 19:48
@aj-stein
Copy link
Contributor Author

Apologies for the delay @SteveLasker. I have moved it from draft status to ready to go.

@SteveLasker SteveLasker requested a review from OR13 November 19, 2024 20:46
@SteveLasker SteveLasker merged commit e7751b5 into ietf-wg-scitt:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants