-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Security Considerations consistent with RFC 3552 #5
Conversation
Signed-off-by: Jon Geater <jon.geater@rkvst.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of Markdown Nits, and some questions on the correlation between Issuer and RBAC, but happy to merge and iterate through additional PRs
* TLS client authentication | ||
|
||
Transparency Services MUST provide a configuration surface that | ||
allows Issuers to specify which authorized clients can submit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a direct correlation between Issuers and Client Auths?
I'm trying to think through the scenarios where this would be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think this should be left to the instance to decide what's right. It's totally legitimate for multiple apps to submit on behalf of the same Issuer, and for a single app to submit Statements signed by many Issuers.
|
||
Replay attacks are not particularly concerning for SCITT or SCRAPI: | ||
once a statement is made it is intended to be immutable and non- | ||
repudiable, so making it twice should not lead to any particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reply attack could be done, that undoes an update:
- An issuer makes a statement, attesting to an artifact has met a set of compliance standards.
{"compliance-2": "true"}
- The issuer discovers a vulnerability, making it no longer compliant with the standard:
{"compliance-2": "false"}
- A reply attack is made, resetting the compliance:
{"compliance-2": "true"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think accumulated state like this is a very good way to use a ledger. Payloads should be complete and make a full statement about whatever they're saying. In your example above the compliance statement should reference which version of the compliance standard was tested against, and what date the assessment was made.
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
I merged the markdown nits, but left the suggestions that should be reviewed by others. |
Co-authored-by: Steve Lasker <stevenlasker@hotmail.com>
Hackathon entry for 119, fill in required elements from RFC 3552