Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Considerations consistent with RFC 3552 #5

Merged
merged 15 commits into from
Mar 22, 2024

Conversation

JAG-UK
Copy link
Contributor

@JAG-UK JAG-UK commented Mar 17, 2024

Hackathon entry for 119, fill in required elements from RFC 3552

Signed-off-by: Jon Geater <jon.geater@rkvst.com>
Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of Markdown Nits, and some questions on the correlation between Issuer and RBAC, but happy to merge and iterate through additional PRs

* TLS client authentication

Transparency Services MUST provide a configuration surface that
allows Issuers to specify which authorized clients can submit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a direct correlation between Issuers and Client Auths?
I'm trying to think through the scenarios where this would be required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think this should be left to the instance to decide what's right. It's totally legitimate for multiple apps to submit on behalf of the same Issuer, and for a single app to submit Statements signed by many Issuers.

draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved
draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved
draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved
draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved
draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved

Replay attacks are not particularly concerning for SCITT or SCRAPI:
once a statement is made it is intended to be immutable and non-
repudiable, so making it twice should not lead to any particular
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reply attack could be done, that undoes an update:

  1. An issuer makes a statement, attesting to an artifact has met a set of compliance standards. {"compliance-2": "true"}
  2. The issuer discovers a vulnerability, making it no longer compliant with the standard: {"compliance-2": "false"}
  3. A reply attack is made, resetting the compliance: {"compliance-2": "true"}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think accumulated state like this is a very good way to use a ledger. Payloads should be complete and make a full statement about whatever they're saying. In your example above the compliance statement should reference which version of the compliance standard was tested against, and what date the assessment was made.

draft-ietf-scitt-scrapi.md Show resolved Hide resolved
draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved
draft-ietf-scitt-scrapi.md Outdated Show resolved Hide resolved
@SteveLasker
Copy link
Collaborator

I merged the markdown nits, but left the suggestions that should be reviewed by others.

Co-authored-by: Steve Lasker <stevenlasker@hotmail.com>
@OR13 OR13 merged commit e53f9b5 into main Mar 22, 2024
2 checks passed
@SteveLasker SteveLasker deleted the dev/jag-uk/security-considerations-section branch March 22, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants