OF-3059 Remove anonymous route #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I restarted the |
|
I did the same for the Smack test, that also consistently fails. There's a bug! There's a bug! Let's fire the author! |
Openfire used the definition of an ‘anonymous route’ in various places (notably the routing table and session manager). An anonymous route should be defined as “a route-able session of which the users has an anonymous authentication token.” A ‘route’ is not inherently anonymous or non-anonymous, a session is. Implementation that previously used the 'anonymous route' definition is interested only in the fact if the corresponding session is anonymous, not if the session is route-able. In this commit, the implementations of methods named `isAnonymousRoute` are deprecated. Their implementation is replaced by checks that evaluate the authentication mechanism used in a session.
To maintain distinction between regular and anonymous ‘routes’, the RoutingTableImpl class used different caches for each. For every use case (other than determining if a ‘route is anonymous’), both caches are operated on. This adds a lot of code complexity, and, as caches are operated on under cluster-wide lock, resource usage. As the 'route is anonymous' concept has been replaced in the previous commit, the only reason to maintain two caches has been removed. This commit removes the AnonymousUserCache completely. All data that was previously stored in either UserCache or AnonymousUserCache is now stored in UserCache.
guusdk
force-pushed
the
OF-3059_Remove-anonymous-route
branch
from
2bba0e5 to
0f8398c
Compare
|
I believe I've found and fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR remove:
Please refer to the individual commit messages for more details.