use ApexCharts instead of HighCharts #117
Conversation
| @@ -6,9 +6,6 @@ | |||
| <title>Rails Performance</title> | |||
| <%= csrf_meta_tags %> | |||
| <%= csp_meta_tag if ::Rails::VERSION::STRING.to_f >= 5.2 %> | |||
| <script> | |||
| window.APP_TIME_ZONE = '<%= Rails.application.config.time_zone.presence || 'UTC' %>'; | |||
There was a problem hiding this comment.
can we keep it and implement something like it?
There was a problem hiding this comment.
@vol1ura maybe some other options can be considered
There was a problem hiding this comment.
Here I try to use option datetimeUTC: false in charts options. It seems the time is displayed correctly now. Please, check
There was a problem hiding this comment.
hmm, maybe it works fine
could you please check if you have the same. I just see some inconsistency and don't know why
There was a problem hiding this comment.
also not sure about this part of the tooltip, I think it's obvious anyway
also not sure but I have a feeling this chart library works slower on mouse hover
but I like the tooltip with time on X-axis
There was a problem hiding this comment.
also not sure about this part of the tooltip, I think it's obvious anyway
Tooltip title can be disabled on all charts, I'll add this param
There was a problem hiding this comment.
I just see some inconsistency and don't know why
I've fixed this issue. Last right label on X axis sometimes doesn't fit, I don't know what to do about it.
There was a problem hiding this comment.
@vol1ura please also move Y axis to the left side. Basically, make a chart very similar to the current version.
After that, I think I can try to release "alpha" version and try it on production
There was a problem hiding this comment.
@igorkasyanchuk ok, done!
There was a problem hiding this comment.
released as
Successfully registered gem: rails_performance (1.4.1.alpha1)
you can try to upgrade.
I also will try to run in on production
vol1ura
force-pushed
the
apexcharts-feature
branch
from
d9e6610 to
3956e4c
Compare
|
PR merged, I think it works fine |
Highcharts license is not free, and there are problems (cors) with loading of the library, so I suggest using Apexcharts, and adding js file to assets as other js.
There is a small difference in the set of options, I tried to keep the previous style of charts.