Added safeguards to prevent crashes when rendering corrupt URLs #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just a simple user of this app, but I, for one, have appreciated all the recent work done by Mr. Schwarz! He was a breath of fresh air to what was a stale product before he arrived on the scene, in my opinion. No offence to ihabunek intended. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urwidgets'
Hyperlinkwidget (correctly) throws an exception when presented with a URL containing disallowed characters (i.e. control characters.) If we get a corrupt URL in a status posting, this will cause a crash. An example of such a status is here. If this loads in the TUI today, ,it will crash.With this PR, we will react to corrupt URLs by rendering as
urwid.Textrather thanHyperlinkand there will be no crash.Given the recent comments about switching to tooi, this will probably be the last PR I submit for the toot tui. It makes more sense to focus efforts on the tooi front end.