Improve Image Support #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change: Execute image class selection logic once and cache the result.
- Fix: Force support support only for the selected image format. If support is forced for `KittyImage`, then `UrwidImageScreen` will emit kitty graphics control sequences to delete images upon starting and stoping the screen. iTerm2 (on Mac OS) doesn't eat up APCs (which kitty graphics control sequences are) as it should, instead it writes them to the screen and/or to its title bar.
danschwarz
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iTerm2 issue was brought to my attention by @danschwarz in AnonymouX47/term-image#90 (comment):
The optimization changes were just things I noticed along the way.