Open
Conversation
mzecc
approved these changes
Mar 17, 2026
Collaborator
mzecc
left a comment
mzecc
left a comment
There was a problem hiding this comment.
Looks good. Markers version is not the latest but maybe this is for a successive PR.
Collaborator
Author
Ye I'll update once markers are locked. Thanks |
Contributor
|
All makes sense to me, some of the driver tweaks are things I normally just do when I run, but good to get it in the flow. |
Collaborator
|
Good, merging this in then. |
Collaborator
Author
True, I probably didn't need to commit them, oh well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maritsandstad can you take a look too please