Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ROS keyring with official ROS Docker images #30

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

cgeller
Copy link
Member

@cgeller cgeller commented Aug 16, 2024

The ROS keyring file is only installed if it does not already exist due to an already installed ROS version.

@jpbusch
Copy link
Collaborator

jpbusch commented Aug 19, 2024

Instead of replacing the path, I would suggest only adding the apt repository if it does not already exist. You could put the relevant places in this if:

if cat /etc/apt/sources.list /etc/apt/sources.list.d/* | grep "http://packages.ros.org/ros2/ubuntu $(. /etc/os-release && echo $UBUNTU_CODENAME) main"; then
  # add apt repo, etc...
fi

@jpbusch jpbusch self-requested a review August 19, 2024 11:14
@jpbusch jpbusch marked this pull request as ready for review August 19, 2024 14:20
@jpbusch jpbusch merged commit 419acd2 into ika-rwth-aachen:main Aug 19, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants