Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rosdep install for non-ROS base images #8

Merged
merged 6 commits into from
Sep 15, 2023

Conversation

jpbusch
Copy link
Collaborator

@jpbusch jpbusch commented Sep 7, 2023

Always installing ros-${ROS_DISTRO}-ros-core and sourcing ROS before rosdep ensures that ROS_VERSION is set for every base-image (especially for using non-ROS base-images) and that standard ROS2 CLI tools like rosrun are always installed.

@jpbusch jpbusch requested a review from lreiher September 7, 2023 14:40
@lreiher
Copy link
Member

lreiher commented Sep 14, 2023

Changes as dicussed:

  • introduce ROS_VERSION as build argument and environment variable
  • set ROS_VERSION automatically based on ROS_DISTRO
    • default to 2
    • only automatically set to 1 if ROS_DISTRO == noetic
    • no explicit list of ROS2 distros required in this case
  • the above is not necessary; we can simply check for noetic, else assume ROS_VERSION=2
  • always install ros-core to guarantee availability of ros2 CLI and more

@lreiher lreiher merged commit 4df1a11 into main Sep 15, 2023
6 checks passed
@lreiher lreiher deleted the fix/rosdep-no-ros-base-image branch September 15, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants