Add support for XZ compression in repomd-parser #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Gemfile.lock to include ruby-xz dependency. - Modified repomd_parser.rb to handle .xz file decompression. - Added XZ compressed XML test case in primary_xml_parser_spec.rb. - Included a sample XZ file in the fixtures for testing.
7 tasks
Owner
|
@ngetahun what Ruby versions does RMT need to support? Tests are breaking now for 3.0 and older because of 3.1 pin in the Gemfile.lock you've added: |
Owner
|
@ngetahun I'm closing this PR in favor of #20, I've added some commits on top of your feature branch to drop Gemfile.lock and fix Rubocop errors so that the tests can run. We can readd Gemfile.lock later, but please talk to the team and figure out what is the oldest Ruby version that has to be supported (i.e. what is the Ruby version on the oldest supported SLES service pack that has RMT). |
Contributor
Author
|
Ah okay, I guess I was using bundler. Thanks for the prompt response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XZ compression is being adopted in rpm repos. Recently EPEL 9 repos have xz compressed metadata. We want RMT to be able to parse such files.