Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest 2023.2 #41

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Update to the latest 2023.2 #41

merged 3 commits into from
Sep 4, 2023

Conversation

maosmurf
Copy link
Contributor

No description provided.

@adamzanyline
Copy link

I confirm the version suggested works locally (after ./gradlew build ) and installing plugin "from disk" to IntelliJ 2023.2 (Build #IU-232.8660.185, built on July 26, 2023)

@ikorennoy
Copy link
Owner

Hi @maosmurf!

Thank you very much for the PR.

@ikorennoy
Copy link
Owner

@maosmurf it looks like there is a problem with windows, would you be able to check what's happened?

@maosmurf
Copy link
Contributor Author

I managed to reproduce, however no clue as how to fix, yet.
Next approach would be to learn from other plugins, most of which moved to gradle8. Will invest time next week.

./gradlew wrapper --gradle-version 8.3
@maosmurf
Copy link
Contributor Author

maosmurf commented Sep 3, 2023

Updated to gradle 8 ( ./gradlew wrapper --gradle-version 8.3 ) , now the plugin builds and runs tests also on my Windows machine.

Now the action "is awaiting approval from a maintainer" 🤞 to run CI on ubuntu and windows.

@ikorennoy ikorennoy merged commit 5a22332 into ikorennoy:master Sep 4, 2023
2 checks passed
@ikorennoy
Copy link
Owner

@maosmurf, now it works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants