Skip to content

Merge from master #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikostan merged 2 commits into from
Sep 10, 2025
Merged

Merge from master #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89f5ee1
Update isbn_verifier.py
ikostan Sep 10, 2025
dd55c49
Merge branch 'main' of https://github.com/ikostan/python
ikostan Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions isbn-verifier/isbn_verifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ def formatted_isbn(isbn: str) -> list[int]:
for char in isbn:
if char.isdigit():
result.append(int(char))
if isbn[-1].lower() == "x":
if isbn[-1] == "X":
result.append(10)

print(f"result: {result}, len: {len(result)}")
return result


Expand All @@ -48,6 +46,7 @@ def is_valid(isbn: str) -> bool:
:return: Tru if isbn is valid, False otherwise
"""
# Non ISBN chars or empty strings not allowed
isbn = isbn.upper()
if not all(char in ISBN for char in isbn.replace("-", "")) or not isbn:
return False
# In case X is present, it should be at the end of the string only
Expand Down