Cancel obsolete requests #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
7fae009
to
e51cc5f
Compare
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
e51cc5f
to
c1bc989
Compare
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
a99e024
to
386d3ea
Compare
m-novikov
force-pushed
the
cancel-tiles-volumina
branch
from
386d3ea
to
4e58dfb
Compare
| @@ -315,6 +317,12 @@ def requestRefresh(self, rectF, stack_id=None, prefetch=False, layer_indexes=Non | |||
| """ | |||
| stack_id = stack_id or self._current_stack_id | |||
| tile_nos = self.tiling.intersected(rectF) | |||
| to_cancel = self._current_requests | |||
| self._current_requests = {} | |||
There was a problem hiding this comment.
Volumina's code is kinda hard to navigate, so I'd love to see some type annotations like
self._current_requests: Mapping[Tuple[LAYER_ID, ImageSource, REQUEST_ID], ArrayRequest] = {}
| else: | ||
| ims_req.cancel() | ||
|
|
||
| self._current_requests.pop((stack_id[1], ims, tile_nr), None) |
There was a problem hiding this comment.
Are you using pop here because the request might have been already removed from self._current_requests?
This kinda makes me think if it would be possible for a request to overwrite an older one; If I, say, load an image in a layer, make a request, drop that layer, then load another image and make another request, is it possible for the second request to overwrite the previous one? Even worse, is it possible for the second one to be cancelled when we meant to cancel the first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.