Cleanup [UI] use FormChipCell component #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-prokopchuk
force-pushed
the
ML-11301
branch
from
4d2add3 to
4a6ac92
Compare
illia-prokopchuk
force-pushed
the
ML-11301
branch
from
4a6ac92 to
615b542
Compare
Taras-Hlukhovetskyi
suggested changes
Nov 17, 2025
| if (!ref.current) return | ||
|
|
||
| const element = ref.current | ||
| const observer = new ResizeObserver(resizeChip) |
There was a problem hiding this comment.
pls add throttle the same as in the useEffect below
| import { setFieldState } from '../../utils/form.util' | ||
| import { CHIP_OPTIONS } from '../../types' | ||
|
|
||
| const ReadOnlyChips = ({ chipOptions = getChipOptions('metrics'), labels = [], ...args }) => { |
There was a problem hiding this comment.
pls move default values to constants chipOptions = getChipOptions('metrics'), labels = []
illia-prokopchuk
force-pushed
the
ML-11301
branch
2 times, most recently
from
d9f1340 to
316470b
Compare
Taras-Hlukhovetskyi
approved these changes
Nov 17, 2025
illia-prokopchuk
force-pushed
the
ML-11301
branch
from
316470b to
7713f52
Compare
illia-prokopchuk
force-pushed
the
ML-11301
branch
from
7713f52 to
01cf989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-11301