Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conda env file #112

Merged
merged 5 commits into from
Feb 14, 2021
Merged

use conda env file #112

merged 5 commits into from
Feb 14, 2021

Conversation

matthiasdiener
Copy link
Member

Closes #111.

@matthiasdiener matthiasdiener marked this pull request as ready for review February 12, 2021 02:22
@MTCam
Copy link
Member

MTCam commented Feb 12, 2021

I love what you've done with this from a pseudo-user perspective. It is very clear what to do in your branch if you need to add packages.

install.sh Outdated Show resolved Hide resolved
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm yo.

install.sh Outdated Show resolved Hide resolved
@matthiasdiener
Copy link
Member Author

good to go @inducer?

@matthiasdiener matthiasdiener merged commit ba5cedc into master Feb 14, 2021
@matthiasdiener matthiasdiener deleted the conda-env-file branch February 14, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mirgecom's conda env file for conda packages
3 participants