Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overintegration tests #1069

Draft
wants to merge 4,859 commits into
base: main
Choose a base branch
from
Draft

Update overintegration tests #1069

wants to merge 4,859 commits into from

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Sep 24, 2024

Track changes to tests for TPEs and overintegration. After the WADG update, overintegration appears to be working properly. This PR will add the tests to show that it is working and some examples that exercise it.

  • Problems using/testing overintegration in mirgecom:
    • overintegration not properly used in WADG (illinois-ceesd/grudge@7c8eaec)
    • TPE normals not on quadrature domain when using overintegration in mirgecom (fixed upstream)
    • grudge integration utility uses mass matrix instead of direct quadrature (illinois-ceesd/grudge@2e54482)
    • mirgecom discretization creation utility does not properly create quadrature domain of correct order for TPE (local)
    • transform chain breaks when setting quadrature order < 2p (illinois-ceesd/loopy@fc274fa)
    • lazy required for quantitative test from Mengaldo to run in pytest didn't work, tests slow

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants