Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CV #569

Closed
wants to merge 13 commits into from
Closed

Split CV #569

wants to merge 13 commits into from

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Dec 12, 2021

Splits ConservedVars into single gas and multi-component gas versions.

This change removes the empty species_mass array for non-mixture states, and introduces a mixture-specific CV structure called MixtureConservedVars. MixtureConservedVars derives from ConservedVars and adds the species_mass array. The change is transparent to most fluid components, but obviates a good deal of special-case processing needed to deal with a ConservedVars that carries around an empty/unused array, at the MIRGE-Com level and below.

fixes: #575

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam changed the base branch from MTCam-patch-1 to main December 13, 2021 01:22
@MTCam MTCam added the refactor label Dec 14, 2021
@MTCam MTCam marked this pull request as ready for review December 14, 2021 15:59
@MTCam MTCam closed this Dec 20, 2021
@MTCam MTCam deleted the split-cv-single-multi branch February 8, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate unneeded empty arrays from ConservedVars
2 participants