Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSPRK43 implemented by THG #863

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Add SSPRK43 implemented by THG #863

merged 2 commits into from
Apr 4, 2023

Conversation

tulioricci
Copy link
Collaborator

@tulioricci tulioricci commented Apr 4, 2023

Add the 4-stages, 3rd order strong-stability preserving Runge-Kutta. Originally implemented in #591

Closes #591 and #601

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam MTCam marked this pull request as ready for review April 4, 2023 15:03
@MTCam MTCam enabled auto-merge (squash) April 4, 2023 15:04
@MTCam MTCam disabled auto-merge April 4, 2023 15:28
@MTCam MTCam merged commit 77b8e07 into main Apr 4, 2023
@MTCam MTCam deleted the tulio/add-ssprk43 branch April 4, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants