Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplified phenolics model #971

Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

Add simplified phenolics model #971

wants to merge 58 commits into from

Conversation

tulioricci
Copy link
Collaborator

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci changed the base branch from main to tulio/init_and_bndry September 26, 2023 20:38
@tulioricci tulioricci changed the base branch from tulio/init_and_bndry to tulio/kappa October 19, 2023 20:18
Base automatically changed from tulio/kappa to main December 6, 2023 19:39
@tulioricci tulioricci changed the base branch from main to use_cantera30 January 31, 2024 18:50
Base automatically changed from use_cantera30 to main February 6, 2024 19:11
@tulioricci tulioricci changed the base branch from main to tulio/riemann-outflow February 21, 2024 14:35
@tulioricci tulioricci changed the title Simplified phenolics model Add simplified phenolics model Feb 21, 2024
@tulioricci tulioricci changed the base branch from tulio/riemann-outflow to tulio/update_mat_intfce March 1, 2024 00:42
@tulioricci tulioricci changed the base branch from tulio/update_mat_intfce to main May 15, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant