fixes opencast-ilias#30 part 2

ilub-unibe-ch · Dec 2, 2024 · e3b6081 · e3b6081
1 parent 9b57d25
commit e3b6081
Showing 1 changed file with 15 additions and 17 deletions.
diff --git a/classes/class.ilOpencastPageComponentPluginGUI.php b/classes/class.ilOpencastPageComponentPluginGUI.php
@@ -525,24 +525,22 @@ protected function setStyleFromProps(ilTemplate $tpl, array $properties)
         $tpl->setVariable('RATIO', $ratio);
         $tpl->setVariable('MAX-WIDTH', $properties[self::PROP_WIDTH]);
         $tpl->setVariable('MAX-HEIGHT', $properties[self::PROP_HEIGHT]);
-        if (array_key_exists(self::PROP_RESPONSIVE, $properties)) {
-            if ($properties[self::PROP_RESPONSIVE] != false) {
-                $tpl->setVariable('WIDTH', 'width:100%;');
-            }
+        if ((bool)($properties[self::PROP_RESPONSIVE] ?? false) === true) {
+            $tpl->setVariable('WIDTH', 'width:100%;');
         }
-        if (array_key_exists(self::PROP_POSITION, $properties)) {
-            switch ($properties[self::PROP_POSITION]) {
-                case self::POSITION_CENTER:
-                    $tpl->setVariable('CONTAINER_STYLE', 'text-align:center;');
-                    break;
-                case self::POSITION_RIGHT:
-                    $tpl->setVariable('CONTAINER_STYLE', 'text-align:right;');
-                    break;
-                case self::POSITION_LEFT:
-                default:
-                    $tpl->setVariable('CONTAINER_STYLE', 'text-align:left;');
-                    break;
-            }
+
+
+        switch ($properties[self::PROP_POSITION] ?? null) {
+            case self::POSITION_CENTER:
+                $tpl->setVariable('CONTAINER_STYLE', 'text-align:center;');
+                break;
+            case self::POSITION_RIGHT:
+                $tpl->setVariable('CONTAINER_STYLE', 'text-align:right;');
+                break;
+            case self::POSITION_LEFT:
+            default:
+                $tpl->setVariable('CONTAINER_STYLE', 'text-align:left;');
+                break;
         }
     }