Intermediate Test - [Priority Queue]#1
Merged
ilya-krivtsov merged 4 commits intomainfrom Apr 25, 2025
Merged
Conversation
| <TargetFramework>net9.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
Что-то StyleCop не подключен, ни тут, ни в тестах. А GlobalSuppressions для него есть
Owner
Author
There was a problem hiding this comment.
Он в Directory.Build.props в корне
| public void Setup() | ||
| { | ||
| queue = Comparer == null ? new() : new(Comparer); | ||
| } |
There was a problem hiding this comment.
Активнее используйте expression-bodied-методы
| /// <param name="comparer">Comparer to use; if <see langword="null"/>, defaults to <see cref="Comparer{TPriority}.Default"/>.</param> | ||
| public PriorityQueue(IComparer<TPriority>? comparer = null) | ||
| { | ||
| head = null; |
There was a problem hiding this comment.
Да оно и так null, явной инициализации в конструкторе не требуется (это же не C++)
| @@ -0,0 +1,76 @@ | |||
| namespace PriorityQueue.Tests; | |||
There was a problem hiding this comment.
Надо ещё шапку с информацией о лицензии
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.